Show "pending" activity in devhub for all versions and not just the latest one #22681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diox
changed the title
diox
commented
Sep 18, 2024
diox
commented
Sep 18, 2024
diox
commented
Sep 18, 2024
diox
requested review from
a team and
KevinMind
and removed request for
a team
KevinMind
reviewed
Sep 20, 2024
KevinMind
reviewed
Sep 20, 2024
KevinMind
reviewed
Sep 20, 2024
KevinMind
reviewed
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: mozilla/addons#15024
Context
See the issue - without this change, for a given add-on in devhub, only the last version in each channel shows the "pending" activity count. This makes it shown on all versions, while not increasing the query count (plenty more to optimize there though, but out of scope)
Testing
See the issue but also the added tests of the model method + test around the view that were added.